Chore: switch tests from freezegun to time-machine#3516
Merged
Conversation
c784370 to
d04ab93
Compare
eakmanrq
reviewed
Dec 14, 2024
eakmanrq
reviewed
Dec 14, 2024
e3512e6 to
9129b2d
Compare
9129b2d to
7801ebc
Compare
7801ebc to
0f52d9c
Compare
erindru
reviewed
Dec 15, 2024
eakmanrq
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libraries used for freezing time in the sqlmesh unit tests.
Change motivated by freezegun's inability to handle timezones.
Notes:
now()would give the same value every timetick=Falseto retain freezegun's default behavior